Miércoles, 16 Abril 2014 04:15
beggarly

HTTPS Problem

Report Xmap bugs on this forum.

HTTPS Problem

Postby greniers » Fri Jan 06, 2012 5:04 am

I have a problem with the XML map.

All the menu link are "https" instead of "http". the params are sets to "secure":1 ON or "secure":-1 OFF gives always https links.

"secure":0 give an "http" this parameter is for IGNORE.

if I change the file displayer.php
from:
line 155: $node->secure = $item->params->get('secure');
to:
line 155: $node->secure = 0;
the "https" change to "http" :D

But I need to use both SSL and non-SSL :(

Edited: SOLUTION?
Finally I remove the changes of the previous file "displayer.php" and change this one

default_class.php into com_xmap\views\xml\tmpl

from:
line 64: $link = JRoute::_($node->link, true, (@$node->secure? 1: -1));

to:
line 64: $link = JRoute::_($node->link, true, ((@$node->secure==0)? -1: $node->secure));

Seems to correct the problem.

versions used are joomla 1.7.3 and xmap 2.2

Thanks for your help
Last edited by greniers on Sun Jan 08, 2012 4:45 am, edited 1 time in total.
greniers
Fresh Boarder
Fresh Boarder
 
Posts: 5
Joined: Fri Jan 06, 2012 4:34 am

HTTPS Problem in HTML

Postby greniers » Fri Jan 06, 2012 6:51 am

I found that the HTTPS links are not implemented into HTML page

I modified the file com_xmap\views\html\tmpl\default_class.php

from:
line 82: $link = JRoute::_($node->link);

to
line 82: $link = JRoute::_($node->link, true, ((@$node->secure==0)? -1: $node->secure));

It seem to work OK
greniers
Fresh Boarder
Fresh Boarder
 
Posts: 5
Joined: Fri Jan 06, 2012 4:34 am

Re: HTTPS Problem

Postby greniers » Sat Jan 28, 2012 6:47 pm

The 2 lines change above should be:

$link = JRoute::_($node->link, true, @$node->secure==0? -1: $node->secure);

just removed two set of () that not needed.
greniers
Fresh Boarder
Fresh Boarder
 
Posts: 5
Joined: Fri Jan 06, 2012 4:34 am

HTTPS links Problem

Postby greniers » Thu Feb 09, 2012 1:26 am

I'm suprised that theses corrections are not into the latest version 2.2.1 :(
greniers
Fresh Boarder
Fresh Boarder
 
Posts: 5
Joined: Fri Jan 06, 2012 4:34 am

Re: HTTPS links Problem

Postby Richard67 » Sun Oct 21, 2012 12:45 pm

greniers wrote:I'm suprised that theses corrections are not into the latest version 2.2.1 :(

And I am disappointed that these corrections have not been included into meanwhile latest 2.3.0 :(
Richard67
Fresh Boarder
Fresh Boarder
 
Posts: 6
Joined: Sun Apr 22, 2012 7:16 am

Re: HTTPS Problem

Postby guilleva » Mon Oct 22, 2012 3:04 pm

Hi, I'm sorry I haven't included this on the latests versions. Can anybody create a pull request for that on Github?

https://github.com/guilleva/Xmap

Please create a fork and then send the pull request.

Thanks,

Guillermo
User avatar
guilleva
Administrator
Administrator
 
Posts: 1527
Joined: Wed Sep 12, 2007 3:10 am
Location: San José, Costa Rica

Re: HTTPS Problem

Postby Richard67 » Sat Oct 27, 2012 11:15 am

guilleva wrote:Can anybody create a pull request for that on Github?

https://github.com/guilleva/Xmap

Please create a fork and then send the pull request.


Hmm, I am a software developer, but in an old-fashioned company, not open source, so I am new with this github. I've looked into the githup help site to find out what this pull request means but I still am not sure if I understand correctly the roles: Is it normally a job of a developer to fork and so on, or is it just a way to let the developer know it needs some change? What is it good for?
Richard67
Fresh Boarder
Fresh Boarder
 
Posts: 6
Joined: Sun Apr 22, 2012 7:16 am

Re: HTTPS Problem

Postby guilleva » Sun Oct 28, 2012 8:49 pm

Hi, fork and pull requests are a very common way to contribute to open source projects. It allows to keep track of those changes and even to give credit to the person who committed the change. You can read more about that on this post:
https://help.github.com/articles/using-pull-requests
User avatar
guilleva
Administrator
Administrator
 
Posts: 1527
Joined: Wed Sep 12, 2007 3:10 am
Location: San José, Costa Rica

Re: HTTPS Problem

Postby Richard67 » Tue Oct 30, 2012 11:46 am

guilleva wrote:Hi, fork and pull requests are a very common way to contribute to open source projects. It allows to keep track of those changes and even to give credit to the person who committed the change. You can read more about that on this post:
https://help.github.com/articles/using-pull-requests

I've checked the post, and it seems to me now that you want someone here to do the developer job.
I could do so, but it requires a github account, which I haven't.
So who else can do it here?
Richard67
Fresh Boarder
Fresh Boarder
 
Posts: 6
Joined: Sun Apr 22, 2012 7:16 am

Re: HTTPS Problem

Postby guilleva » Tue Oct 30, 2012 2:12 pm

Hi,

it looks to me that there is more than one developer here, I'm just saying that the best way to share the changes/fixes is using github and don't get surprised or disappointed if the changes that you shared (which I don't fully understand) were not included on the latest version of Xmap.

I really sorry that I haven't included them, I need to take some time to try to reproduce the problem, that isn't very clear on the original post either, and then apply the fix and test. I haven't had the time yet and I will certainly do it at some point if no one can help with the pull request, or at least, share the modified file (hopefully the file taken from the latest version of Xmap).

Doing pull requests is not doing somebody else's job it's just a much nicer and cleaner way to do what is being done here.

Regards,

Guille
User avatar
guilleva
Administrator
Administrator
 
Posts: 1527
Joined: Wed Sep 12, 2007 3:10 am
Location: San José, Costa Rica

Next

Return to Bugs



Who is online

Users browsing this forum: Google Adsense [Bot] and 2 guests