Domingo, 21 Septiembre 2014 16:11
beggarly

Filtered News - htmlspecialchars twice in static

Report Xmap bugs on this forum.

Filtered News - htmlspecialchars twice in static

Postby naimless » Sun Mar 24, 2013 5:50 pm

Sorry for posting here - unfortunately the Filtered News category is locked, so I'd post this short bug report here.

First off, amazing component. So simple, yet so much depth and customisation possible. I love it!

Anyway, in Filtered News helper.php, around line 280 it says

Code: Select all
$row->title = htmlspecialchars( $row->title );


This causes a bug for me, since 5 lines down htmlspecialchars is applied again to the title, causing & and other special characters to be output as & when using the static mode (not sure about other modes), etc.

When I removed this, it was working fine - might want to consider updating in next version if this is a problem for you too.

Also, there are a few unnecessary SQL queries being done - even though category exclusion is deselected, for example, it still JOINS the cat table, etc. Might be worth looking into, though generally it's quite fast anyway.
naimless
Fresh Boarder
Fresh Boarder
 
Posts: 1
Joined: Sun May 01, 2011 7:25 pm

Return to Bugs



Who is online

Users browsing this forum: No registered users and 4 guests